Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3865#discussion_r116224135
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java ---
@@ -111,34 +111,32 @@ private BlobServer(Configuration config, BlobStore
blobStore) throws IOException
this.blobStore = checkNotNull(blobStore);
// configure and create the storage directory
- String storageDirectory =
config.getString(ConfigConstants.BLOB_STORAGE_DIRECTORY_KEY, null);
+ String storageDirectory =
config.getString(BlobServerOptions.STORAGE_DIRECTORY);
this.storageDir =
BlobUtils.initStorageDirectory(storageDirectory);
LOG.info("Created BLOB server storage directory {}",
storageDir);
// configure the maximum number of concurrent connections
- final int maxConnections = config.getInteger(
- ConfigConstants.BLOB_FETCH_CONCURRENT_KEY,
ConfigConstants.DEFAULT_BLOB_FETCH_CONCURRENT);
+ final int maxConnections =
config.getInteger(BlobServerOptions.FETCH_CONCURRENT);
if (maxConnections >= 1) {
--- End diff --
Do you think we should refactor some bounds checking and warning into
`ConfigOptions`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
