Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3883#discussion_r116249086
--- Diff:
flink-core/src/main/java/org/apache/flink/core/io/VersionedIOReadableWritable.java
---
@@ -18,55 +18,66 @@
package org.apache.flink.core.io;
-import org.apache.flink.annotation.PublicEvolving;
+import org.apache.flink.annotation.Internal;
import org.apache.flink.core.memory.DataInputView;
import org.apache.flink.core.memory.DataOutputView;
import java.io.IOException;
+import java.util.Arrays;
/**
* This is the abstract base class for {@link IOReadableWritable} which
allows to differentiate between serialization
* versions. Concrete subclasses should typically override the {@link
#write(DataOutputView)} and
* {@link #read(DataInputView)}, thereby calling super to ensure version
checking.
*/
-@PublicEvolving
+@Internal
public abstract class VersionedIOReadableWritable implements
IOReadableWritable, Versioned {
+ private Integer readVersion;
--- End diff --
I think I would not use `Integer` here but `int` instead and have some
undefined value, e.g. `Integer.MIN_VALUE`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
