Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3897#discussion_r116433350
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/fieldExpression.scala
---
@@ -132,31 +134,61 @@ case class WindowReference(name: String) extends
Attribute {
throw new ValidationException("Cannot rename window reference.")
}
}
+
+ override def toString: String = s"'$name"
}
abstract class TimeAttribute(val expression: Expression)
extends UnaryExpression
- with NamedExpression {
+ with WindowProperty {
override private[flink] def child: Expression = expression
-
- override private[flink] def name: String = expression match {
- case UnresolvedFieldReference(name) => name
- case _ => throw new ValidationException("Unresolved field reference
expected.")
- }
-
- override private[flink] def toAttribute: Attribute =
- throw new UnsupportedOperationException("Time attribute can not be
used solely.")
}
case class RowtimeAttribute(expr: Expression) extends TimeAttribute(expr) {
- override private[flink] def resultType: TypeInformation[_] =
+ override private[flink] def validateInput(): ValidationResult = {
+ child match {
+ case WindowReference(_, Some(tpe)) if !isRowtimeIndicatorType(tpe) =>
+ ValidationFailure("A proctime window can not guarantee a rowtime
attribute.")
--- End diff --
-> "A proctime window cannot provide a rowtime attribute"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
