[
https://issues.apache.org/jira/browse/FLINK-6517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16010180#comment-16010180
]
ASF GitHub Bot commented on FLINK-6517:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3897#discussion_r116433350
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/fieldExpression.scala
---
@@ -132,31 +134,61 @@ case class WindowReference(name: String) extends
Attribute {
throw new ValidationException("Cannot rename window reference.")
}
}
+
+ override def toString: String = s"'$name"
}
abstract class TimeAttribute(val expression: Expression)
extends UnaryExpression
- with NamedExpression {
+ with WindowProperty {
override private[flink] def child: Expression = expression
-
- override private[flink] def name: String = expression match {
- case UnresolvedFieldReference(name) => name
- case _ => throw new ValidationException("Unresolved field reference
expected.")
- }
-
- override private[flink] def toAttribute: Attribute =
- throw new UnsupportedOperationException("Time attribute can not be
used solely.")
}
case class RowtimeAttribute(expr: Expression) extends TimeAttribute(expr) {
- override private[flink] def resultType: TypeInformation[_] =
+ override private[flink] def validateInput(): ValidationResult = {
+ child match {
+ case WindowReference(_, Some(tpe)) if !isRowtimeIndicatorType(tpe) =>
+ ValidationFailure("A proctime window can not guarantee a rowtime
attribute.")
--- End diff --
-> "A proctime window cannot provide a rowtime attribute"?
> Support multiple consecutive windows
> ------------------------------------
>
> Key: FLINK-6517
> URL: https://issues.apache.org/jira/browse/FLINK-6517
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Timo Walther
> Priority: Critical
> Fix For: 1.3.0
>
>
> FLINK-5884 changed the way how windows can be defined, however, it is not
> possible to define multiple consecutive windows right now. It should be
> possible to refine the end property of a window as a new time attribute.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
