Github user godfreyhe commented on a diff in the pull request:
https://github.com/apache/flink/pull/3860#discussion_r116451558
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/PhysicalTableSourceScan.scala
---
@@ -70,4 +73,18 @@ abstract class PhysicalTableSourceScan(
def copy(traitSet: RelTraitSet, tableSource: TableSource[_]):
PhysicalTableSourceScan
+ override def estimateRowCount(mq: RelMetadataQuery): Double = {
+ val tableSourceTable = getTable.unwrap(classOf[TableSourceTable[_]])
+
+ if (tableSourceTable.getStatistic != FlinkStatistic.UNKNOWN) {
--- End diff --
The basic idea of current accessing order is let each ``TableSource``
decide its statistic (Only it knows how to get correct statistic. And in
future there are different kinds of ``XXXTableSource`` ).
we can change the result value of ``fromExternalCatalogTable`` method in
``TableSourceConverter``:
``
def fromExternalCatalogTable(externalCatalogTable: ExternalCatalogTable):
(T, TableStats)
``
Currently, if a table source is ``FilterableTableSource``, the returned
``TableStats`` is null.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
