[
https://issues.apache.org/jira/browse/FLINK-6581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16010269#comment-16010269
]
ASF GitHub Bot commented on FLINK-6581:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/3903
[FLINK-6581] [cli] Correct dynamic property parsing for YARN cli
The YARN cli will now split the dynamic propertie at the first occurrence of
the = sign instead of splitting it at every = sign. That way we support
dynamic
properties of the form -yDenv.java.opts="-DappName=foobar".
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink fixYarnDynPropertyParsing
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3903.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3903
----
commit 5988d06fd5bc8e6a20e924bb009aaf3f9b5f884b
Author: Till Rohrmann <[email protected]>
Date: 2017-05-15T10:04:07Z
[FLINK-6581] [cli] Correct dynamic property parsing for YARN cli
The YARN cli will now split the dynamic propertie at the first occurrence of
the = sign instead of splitting it at every = sign. That way we support
dynamic
properties of the form -yDenv.java.opts="-DappName=foobar".
----
> Dynamic property parsing broken for YARN
> ----------------------------------------
>
> Key: FLINK-6581
> URL: https://issues.apache.org/jira/browse/FLINK-6581
> Project: Flink
> Issue Type: Bug
> Components: YARN
> Affects Versions: 1.3.0, 1.4.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
>
> The dynamic property parsing in YARN is broken. For example, the following
> dynamic property won't be parsed properly:
> {{-yDenv.java.opts="-DappName=foobar -Did=1"}}. The result will be equivalent
> to {{-yDenv.java.opts="-DappName"}}.
> The problem is that {{FlinkYarnSessionCli#getDynamicProperties}} assumes that
> all dynamic properties have the form {{-D<KEY>=<VALUE>}} where {{<VALUE>}}
> does not contain any {{=}}.
> I propose to change the parsing of the dynamic properties string such that it
> splits the key-value pair not via {{dynamicProperties.split("=")}} but that
> we split the dynamic properties string at the first occurrence of the {{=}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
