[
https://issues.apache.org/jira/browse/FLINK-6598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012206#comment-16012206
]
sunjincheng commented on FLINK-6598:
------------------------------------
Hi, [~fhueske], I think:
1. for `DataStreamGroupAggregate`, if we want get distinct keys we can using
[FLINK-6428|https://issues.apache.org/jira/browse/FLINK-6428](the PR. need
updated tomorrow).
2. for `DataStreamGroupWindowAggregate` we also need something like
[FLINK-6428|https://issues.apache.org/jira/browse/FLINK-6428] to deal with.
I agree that the functionality can get distinct keys. but user will be a little
confused. Because for SQL user, they only know `DISTINCT` keyword can get the
get distinct fields(keys).
What do you think?
Best,
SunJincheng
> Fix `DataStreamGroupAggregateRule`and `DataStreamGroupWindowAggregateRule`
> matches error.
> -----------------------------------------------------------------------------------------
>
> Key: FLINK-6598
> URL: https://issues.apache.org/jira/browse/FLINK-6598
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
> Reporter: sunjincheng
> Assignee: sunjincheng
> Fix For: 1.3.0
>
>
> Changes as follows:
> 1. Add {{!agg.getAggCallList.isEmpty}} condition for
> {{DataStreamGroupWindowAggregateRule}} and {{DataStreamGroupAggregateRule}}.
> 2. Remove useless param {{rowRelDataType}} of {{DataStreamGroupAggregate}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
