Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3913#discussion_r116721601
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/CrudExternalCatalog.scala
 ---
    @@ -96,13 +93,14 @@ trait CrudExternalCatalog extends ExternalCatalog {
       /**
         * Modifies an existing database in the catalog.
         *
    +    * @param dbName            Name of the database.
         * @param db                New description of the database to update
         * @param ignoreIfNotExists Flag to specify behavior if the database 
does not exist:
         *                          if set to false, throw an exception,
         *                          if set to true, nothing happens.
         * @throws DatabaseNotExistException thrown if the database does not 
exist in the catalog
         */
       @throws[DatabaseNotExistException]
    -  def alterDatabase(db: ExternalCatalogDatabase, ignoreIfNotExists: 
Boolean): Unit
    +  def alterDatabase(dbName: String, db: ExternalCatalog, 
ignoreIfNotExists: Boolean): Unit
    --- End diff --
    
    rename to `alterSubCatalog()` or add an alias method?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to