[ 
https://issues.apache.org/jira/browse/FLINK-6598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012472#comment-16012472
 ] 

sunjincheng edited comment on FLINK-6598 at 5/16/17 2:26 PM:
-------------------------------------------------------------

Yes, DISTINCT works by `group by ` + `join`. in DataSet. In this PR. we only do 
one thing: 
* Remove useless param rowRelDataType of DataStreamGroupAggregate.


Best,
SunJincheng


was (Author: sunjincheng121):
Yes, DISTINCT works by `group by ` + `join`. in DataSet. In this PR. we only do 
one thing: 
* Remove useless param rowRelDataType of DataStreamGroupAggregate.
Best,
SunJincheng

> Fix `DataStreamGroupAggregateRule`and `DataStreamGroupWindowAggregateRule` 
> matches error.
> -----------------------------------------------------------------------------------------
>
>                 Key: FLINK-6598
>                 URL: https://issues.apache.org/jira/browse/FLINK-6598
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>            Reporter: sunjincheng
>            Assignee: sunjincheng
>             Fix For: 1.3.0
>
>
> Changes as follows:
> 1. Add {{!agg.getAggCallList.isEmpty}} condition for 
> {{DataStreamGroupWindowAggregateRule}} and {{DataStreamGroupAggregateRule}}.
> 2. Remove useless param {{rowRelDataType}} of {{DataStreamGroupAggregate}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to