[
https://issues.apache.org/jira/browse/FLINK-6543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014353#comment-16014353
]
ASF GitHub Bot commented on FLINK-6543:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3929#discussion_r117050100
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/java/StreamTableEnvironment.scala
---
@@ -144,13 +144,119 @@ class StreamTableEnvironment(
* types: Fields are mapped by position, field types must match.
* - POJO [[DataStream]] types: Fields are mapped by field name, field
types must match.
*
+ * NOTE: This method only supports conversion of append-only tables. In
order to make this
+ * more explicit in the future, please use [[toAppendStream()]] instead.
+ * If add and retract messages are required, use [[toRetractStream()]].
+ *
+ * @param table The [[Table]] to convert.
+ * @param clazz The class of the type of the resulting [[DataStream]].
+ * @tparam T The type of the resulting [[DataStream]].
+ * @return The converted [[DataStream]].
+ * @deprecated This method only supports conversion of append-only
tables. In order to
+ * make this more explicit in the future, please use
toAppendStream() instead.
+ */
+ @Deprecated
+ def toDataStream[T](table: Table, clazz: Class[T]): DataStream[T] =
toAppendStream(table, clazz)
--- End diff --
This method is still referenced from the `java` `package-info.java` file
and the `java` `SqlITCase`.
> Deprecate toDataStream
> ----------------------
>
> Key: FLINK-6543
> URL: https://issues.apache.org/jira/browse/FLINK-6543
> Project: Flink
> Issue Type: Task
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Timo Walther
> Fix For: 1.3.0
>
>
> With retraction support, we should deprecate {{toDataStream}} and introduce a
> new {{toAppendStream}} to clearly differentiate between retraction and
> non-retraction.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
