[
https://issues.apache.org/jira/browse/FLINK-6618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015213#comment-16015213
]
ASF GitHub Bot commented on FLINK-6618:
---------------------------------------
GitHub user sunjincheng121 opened a pull request:
https://github.com/apache/flink/pull/3936
[FLINK-6618][table] Fix GroupWindowStringExpressionTest test case bug
In this PR. I had fix the `GroupWindowStringExpressionTest` test case bug
- [x] General
- The pull request references the related JIRA issue
("[FLINK-6618][table] Fix GroupWindowStringExpressionTest testcase bug")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sunjincheng121/flink FLINK-6618-PR
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3936.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3936
----
commit f331798000bbf8ce6316862545c761583e8b9eef
Author: sunjincheng121 <sunjincheng...@gmail.com>
Date: 2017-05-18T05:02:24Z
[FLINK-6618][table] Fix GroupWindowStringExpressionTest testcase bug
----
> Fix GroupWindowStringExpressionTest testcase bug
> ------------------------------------------------
>
> Key: FLINK-6618
> URL: https://issues.apache.org/jira/browse/FLINK-6618
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Affects Versions: 1.3.0
> Reporter: sunjincheng
> Assignee: sunjincheng
>
> I find 2 bugs as follows:
> 1. {{GroupWindowStringExpressionTest}} testcase bug:
> {{Assert.assertEquals("Logical Plans do not match", resJava.logicalPlan,
> resJava.logicalPlan)}} -> {{Assert.assertEquals("Logical Plans do not match",
> resJava.logicalPlan, resScala.logicalPlan)}}
> 2. When i fix the bug above, we got anther bug:
> {code}
> java.lang.AssertionError: Logical Plans do not match
> Expected :Project(ListBuffer('string, 'TMP_4, 'TMP_5, 'TMP_6, ('TMP_7 * 2) as
> '_c4),WindowAggregate(List('string),SlidingGroupWindow('w, 'rowtime,
> 14400000.millis, 7200000.millis),List(),List(CountAggFunction(List('string))
> as 'TMP_4, sum('int) as 'TMP_5, WeightedAvg(List('long, 'int)) as 'TMP_6,
> WeightedAvg(List('int, 'int)) as 'TMP_7),Project(ArrayBuffer('string, 'int,
> 'long,
> 'rowtime),CatalogNode(WrappedArray(_DataStreamTable_0),RecordType(INTEGER
> int, BIGINT long, VARCHAR(2147483647) string, TIMESTAMP(3) rowtime)))))
> Actual :Project(ListBuffer('string, 'TMP_0, 'TMP_1, 'TMP_2, ('TMP_3 * 2) as
> '_c4),WindowAggregate(ArrayBuffer('string),SlidingGroupWindow('w, 'rowtime,
> 14400000.millis,
> 7200000.millis),List(),List(CountAggFunction(ArrayBuffer('string)) as 'TMP_0,
> sum('int) as 'TMP_1, WeightedAvg(ArrayBuffer('long, 'int)) as 'TMP_2,
> WeightedAvg(ArrayBuffer('int, 'int)) as 'TMP_3),Project(ArrayBuffer('string,
> 'int, 'long,
> 'rowtime),CatalogNode(WrappedArray(_DataStreamTable_0),RecordType(INTEGER
> int, BIGINT long, VARCHAR(2147483647) string, TIMESTAMP(3) rowtime)))))
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
