[
https://issues.apache.org/jira/browse/FLINK-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015492#comment-16015492
]
ASF GitHub Bot commented on FLINK-6031:
---------------------------------------
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3931#discussion_r117198446
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
@@ -200,6 +214,17 @@ public void setTaskManagerMemory(int memoryMb) {
public void
setFlinkConfiguration(org.apache.flink.configuration.Configuration conf) {
this.flinkConfiguration = conf;
+
+ String configuredUserJarInclusion =
flinkConfiguration.getString(YarnConfigOptions.CLASSPATH_INCLUDE_USER_JAR);
+ try {
+ userJarInclusion =
YarnConfigOptions.UserJarInclusion.valueOf(configuredUserJarInclusion.toUpperCase());
+ } catch (IllegalArgumentException e) {
+ LOG.warn("Configuration parameter {} was configured
with an invalid value {}. Falling back to default ({}).",
+
YarnConfigOptions.CLASSPATH_INCLUDE_USER_JAR.key(),
+ configuredUserJarInclusion,
+
YarnConfigOptions.CLASSPATH_INCLUDE_USER_JAR.defaultValue());
+ userJarInclusion =
YarnConfigOptions.UserJarInclusion.valueOf(YarnConfigOptions.CLASSPATH_INCLUDE_USER_JAR.defaultValue());
+ }
--- End diff --
This code and the code above looks like exactly the same.
If this is duplicate code, it should be extracted into one method?
> Add parameter for per job yarn clusters to control whether the user code jar
> is included into the system classloader.
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: FLINK-6031
> URL: https://issues.apache.org/jira/browse/FLINK-6031
> Project: Flink
> Issue Type: Bug
> Components: YARN
> Reporter: Robert Metzger
> Assignee: Chesnay Schepler
> Priority: Critical
>
> FLINK-4913 added the user jar into the system classloader, when starting a
> Flink per job YARN cluster.
> Some users were experiencing issues with the changed behavior.
> I suggest to introduce a new yarn specific configuration parameter (for the
> flink-conf.yaml file) to control if the user jar is added into system
> classloader.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
