[ 
https://issues.apache.org/jira/browse/FLINK-6606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015711#comment-16015711
 ] 

ASF GitHub Bot commented on FLINK-6606:
---------------------------------------

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/3933
  
    Thanks for your contribution @EronWright. I'm not quite sure whether I 
understand which problem we are trying to solve here. 
    
    I think by deserializing the `MasterTriggerRestoreHook.Factories` with the 
user code class loader in `ExecutionGraphBuilder.java:253`, we support user 
code hooks. Given that the `Factory` is a user defined class, then it should 
get the user code class loader set as its `ClassLoader`. Thus, it should also 
be able to load a user defined `MasterTriggerRestoreHook` class. And the latter 
can only be a user defined class if the factory is user defined.
    
    But I might be overlooking something here. Maybe you can give me some more 
details about the PR.


> Create checkpoint hook with user classloader
> --------------------------------------------
>
>                 Key: FLINK-6606
>                 URL: https://issues.apache.org/jira/browse/FLINK-6606
>             Project: Flink
>          Issue Type: Bug
>          Components: State Backends, Checkpointing
>            Reporter: Eron Wright 
>            Assignee: Eron Wright 
>            Priority: Blocker
>             Fix For: 1.3.0
>
>
> Flink should set the thread's classloader when calling the checkpoint hook 
> factory's `create` method.   Without that, the hook is likely to fail during 
> initialization (e.g. using ServiceLoader). 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to