[ 
https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16016789#comment-16016789
 ] 

ASF GitHub Bot commented on FLINK-6495:
---------------------------------------

Github user zjureel commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3935#discussion_r117390018
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/configuration/AkkaOptions.java ---
    @@ -28,31 +28,143 @@
     @PublicEvolving
     public class AkkaOptions {
     
    +   public static String DEFAULT_AKKA_TRANSPORT_HEARTBEAT_INTERVAL = "1000 
s";
    +
    +   public static String DEFAULT_AKKA_TCP_TIMEOUT = "20 s";
    +
    +   public static String DEFAULT_AKKA_WATCH_HEARTBEAT_INTERVAL = "10 s";
    --- End diff --
    
    Thank you for your suggestion, and I was also bothered by the 
`DEFAULT_AKKA_*` fields while the default value is used. 
`ConfigOption#defaultValue()` sounds good.


> Migrate Akka configuration options
> ----------------------------------
>
>                 Key: FLINK-6495
>                 URL: https://issues.apache.org/jira/browse/FLINK-6495
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination, Network
>            Reporter: Chesnay Schepler
>            Assignee: Fang Yong
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to