[ 
https://issues.apache.org/jira/browse/FLINK-6634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017378#comment-16017378
 ] 

ASF GitHub Bot commented on FLINK-6634:
---------------------------------------

Github user kl0u commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3945#discussion_r117477471
  
    --- Diff: 
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
    @@ -930,6 +930,7 @@ public void serialize(NFA<T> record, DataOutputView 
target) throws IOException {
                                
timestampSerializer.serialize(computationState.getTimestamp(), target);
                                
versionSerializer.serialize(computationState.getVersion(), target);
                                
timestampSerializer.serialize(computationState.getStartTimestamp(), target);
    +                           target.writeInt(computationState.getCounter());
    --- End diff --
    
    The `counter` field was introduced in Flink 1.3 and the new serializer is 
only used in Flink 1.3. Before it was Java Serialization, so if you see in the 
`readComputationState()` we create a computation state with 0.


> NFA serializer does not serialize the ValueTimeWrapper counter.
> ---------------------------------------------------------------
>
>                 Key: FLINK-6634
>                 URL: https://issues.apache.org/jira/browse/FLINK-6634
>             Project: Flink
>          Issue Type: Bug
>          Components: CEP
>    Affects Versions: 1.3.0
>            Reporter: Kostas Kloudas
>            Assignee: Kostas Kloudas
>             Fix For: 1.3.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to