[
https://issues.apache.org/jira/browse/FLINK-6586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017384#comment-16017384
]
ASF GitHub Bot commented on FLINK-6586:
---------------------------------------
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3907#discussion_r117479119
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputGateMetrics.java
---
@@ -86,6 +86,9 @@ int refreshAndGetMin() {
}
}
+ if (min == Integer.MAX_VALUE) { // in case all channels are
local
--- End diff --
Is it worth removing the earlier check for `channels.isEmpty()` and merging
the comments?
> InputGateMetrics#refreshAndGetMin returns Integer.MAX_VALUE for local channels
> ------------------------------------------------------------------------------
>
> Key: FLINK-6586
> URL: https://issues.apache.org/jira/browse/FLINK-6586
> Project: Flink
> Issue Type: Bug
> Components: Metrics, Network
> Affects Versions: 1.3.0, 1.4.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Trivial
> Fix For: 1.3.0, 1.4.0
>
>
> The {{InputGateMetrics#refreshAndGetMin}} returns {{Integer.MAX_VALUE}} when
> working with {{LocalChannels}}. In this case it should return 0 instead.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
