[ 
https://issues.apache.org/jira/browse/FLINK-6642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017553#comment-16017553
 ] 

ASF GitHub Bot commented on FLINK-6642:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/3956

    [FLINK-6642] Return -1 in EnvInfo#getOpenFileHandlesLimit

    Returns -1 for Windows, as the accessed UnixOSMXBean is obviously not 
available on Windows.
    
    This reduces logging noise on Windows.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 6642_env_windows

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3956.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3956
    
----
commit 4060e8b1a1f4cde1674a5f41dd4a925679bd5d55
Author: zentol <ches...@apache.org>
Date:   2017-05-19T15:22:26Z

    [FLINK-6642] Return -1 in EnvInfo#getOpenFileHandlesLimit

----


> EnvInformation#getOpenFileHandlesLimit should return -1 for Windows
> -------------------------------------------------------------------
>
>                 Key: FLINK-6642
>                 URL: https://issues.apache.org/jira/browse/FLINK-6642
>             Project: Flink
>          Issue Type: Bug
>          Components: Local Runtime
>    Affects Versions: 1.4.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>
> The {{EnvironmentInformation#getOpenFileHandlesLimit}} is accessing the sun 
> {{UnixOperatingSystemMXBean}} via reflection, but has no branch for Windows.
> This causes the following exception to be logged whenever a TM is started:
> {code}
> 2017-05-19 16:49:58,780 WARN  
> org.apache.flink.runtime.util.EnvironmentInformation          - Unexpected 
> error when accessing file handle limit
> java.lang.IllegalArgumentException: object is not an instance of declaring 
> class
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>         at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
>         at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
>         at java.lang.reflect.Method.invoke(Unknown Source)
>         at 
> org.apache.flink.runtime.util.EnvironmentInformation.getOpenFileHandlesLimit(EnvironmentInformation.java:245)
>         at 
> org.apache.flink.runtime.taskmanager.TaskManager$.main(TaskManager.scala:1528)
>         at 
> org.apache.flink.runtime.taskmanager.TaskManager.main(TaskManager.scala)
> 2017-05-19 16:49:58,780 INFO  
> org.apache.flink.runtime.taskmanager.TaskManager              - Cannot 
> determine the maximum number of open file descriptors
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to