[
https://issues.apache.org/jira/browse/FLINK-6603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16019384#comment-16019384
]
ASF GitHub Bot commented on FLINK-6603:
---------------------------------------
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3941
@greghogan Do we have a checkstyle rule for an empty line before the
package declaration? I saw you added a commit for it, but couldn't find the
corresponding checkstyle rule.
Travis is also failing at the moment due to a checkstyle violation:
```[ERROR]
src/test/java/org/apache/flink/streaming/util/OperatorSnapshotUtil.java:[51]
(regexp) RegexpSingleline: Trailing whitespace```
> Enable checkstyle on test sources
> ---------------------------------
>
> Key: FLINK-6603
> URL: https://issues.apache.org/jira/browse/FLINK-6603
> Project: Flink
> Issue Type: Improvement
> Components: DataStream API
> Affects Versions: 1.4.0
> Reporter: Greg Hogan
> Assignee: Greg Hogan
> Priority: Trivial
> Fix For: 1.4.0
>
>
> With the addition of strict checkstyle to select modules (currently limited
> to {{flink-streaming-java}}) we can enable the checkstyle flag
> {{includeTestSourceDirectory}} to perform the same unused imports,
> whitespace, and other checks on test sources.
> Should first resolve the import grouping as discussed in FLINK-6107. Also,
> several tests exceed the 2500 line limit.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
