[
https://issues.apache.org/jira/browse/FLINK-6431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021188#comment-16021188
]
ASF GitHub Bot commented on FLINK-6431:
---------------------------------------
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3968#discussion_r117987690
--- Diff:
flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java
---
@@ -146,44 +146,38 @@ public void report() {
}
/**
- * Get config tags from config 'metrics.reporter.dghttp.tags'
- * */
+ * Get config tags from config 'metrics.reporter.dghttp.tags'.
+ */
private List<String> getTagsFromConfig(String str) {
return Arrays.asList(str.split(","));
}
/**
- * Get tags from MetricGroup#getAllVariables(), excluding 'host'
- * */
+ * Get tags from MetricGroup#getAllVariables(), excluding 'host'.
+ */
private List<String> getTagsFromMetricGroup(MetricGroup metricGroup) {
List<String> tags = new ArrayList<>();
for (Map.Entry<String, String> entry:
metricGroup.getAllVariables().entrySet()) {
- if(!entry.getKey().equals(HOST_VARIABLE)) {
+ if (!entry.getKey().equals(HOST_VARIABLE)) {
tags.add(getVariableName(entry.getKey()) + ":"
+ entry.getValue());
}
}
return tags;
}
- /**
- * Get host from MetricGroup#getAllVariables() if it exists; returns
Null otherwise
- * */
private String getHostFromMetricGroup(MetricGroup metricGroup) {
return metricGroup.getAllVariables().get(HOST_VARIABLE);
}
- /**
- * Given "<xxx>", return "xxx"
--- End diff --
Could be helpful to leave a comment noting the removal of the leading and
trailing angle brackets.
> Activate strict checkstyle for flink-metrics
> --------------------------------------------
>
> Key: FLINK-6431
> URL: https://issues.apache.org/jira/browse/FLINK-6431
> Project: Flink
> Issue Type: Improvement
> Components: Metrics
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
