Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3973#discussion_r118058165
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/TaskManagerLogHandler.java
---
@@ -100,26 +101,27 @@
private static final String TASKMANAGER_LOG_REST_PATH =
"/taskmanagers/:taskmanagerid/log";
private static final String TASKMANAGER_OUT_REST_PATH =
"/taskmanagers/:taskmanagerid/stdout";
- /** Keep track of last transmitted log, to clean up old ones */
+ /** Keep track of last transmitted log, to clean up old ones. */
private final HashMap<String, BlobKey> lastSubmittedLog = new
HashMap<>();
private final HashMap<String, BlobKey> lastSubmittedStdout = new
HashMap<>();
- /** Keep track of request status, prevents multiple log requests for a
single TM running concurrently */
+ /** Keep track of request status, prevents multiple log requests for a
single TM running concurrently. */
private final ConcurrentHashMap<String, Boolean> lastRequestPending =
new ConcurrentHashMap<>();
private final Configuration config;
- /** Future of the blob cache */
+ /** Future of the blob cache. */
private Future<BlobCache> cache;
- /** Indicates which log file should be displayed; true indicates .log,
false indicates .out */
- private boolean serveLogFile;
+ /** Indicates which log file should be displayed;. */
--- End diff --
Unnecessary semicolon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
