[ 
https://issues.apache.org/jira/browse/FLINK-6687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021622#comment-16021622
 ] 

ASF GitHub Bot commented on FLINK-6687:
---------------------------------------

Github user greghogan commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3973#discussion_r118058165
  
    --- Diff: 
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/TaskManagerLogHandler.java
 ---
    @@ -100,26 +101,27 @@
        private static final String TASKMANAGER_LOG_REST_PATH = 
"/taskmanagers/:taskmanagerid/log";
        private static final String TASKMANAGER_OUT_REST_PATH = 
"/taskmanagers/:taskmanagerid/stdout";
     
    -   /** Keep track of last transmitted log, to clean up old ones */
    +   /** Keep track of last transmitted log, to clean up old ones. */
        private final HashMap<String, BlobKey> lastSubmittedLog = new 
HashMap<>();
        private final HashMap<String, BlobKey> lastSubmittedStdout = new 
HashMap<>();
     
    -   /** Keep track of request status, prevents multiple log requests for a 
single TM running concurrently */
    +   /** Keep track of request status, prevents multiple log requests for a 
single TM running concurrently. */
        private final ConcurrentHashMap<String, Boolean> lastRequestPending = 
new ConcurrentHashMap<>();
        private final Configuration config;
     
    -   /** Future of the blob cache */
    +   /** Future of the blob cache. */
        private Future<BlobCache> cache;
     
    -   /** Indicates which log file should be displayed; true indicates .log, 
false indicates .out */
    -   private boolean serveLogFile;
    +   /** Indicates which log file should be displayed;. */
    --- End diff --
    
    Unnecessary semicolon.


> Activate strict checkstyle for flink-runtime-web
> ------------------------------------------------
>
>                 Key: FLINK-6687
>                 URL: https://issues.apache.org/jira/browse/FLINK-6687
>             Project: Flink
>          Issue Type: Improvement
>          Components: Webfrontend
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to