[
https://issues.apache.org/jira/browse/FLINK-6654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022485#comment-16022485
]
ASF GitHub Bot commented on FLINK-6654:
---------------------------------------
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3960
I'm not sure if the proposed fix is correct, because it will add the shaded
hadoop uber project's dependencies into Flink dist.
IIRC, this was the whole point of Stephan's recent refactoring of the
dependencies.
I did a quick check, just based on the flink-dist file size and content,
and with the current rel 1.3 branch, we have the following file sizes:
```
-rw-r--r-- 1 robert robert 68M May 24 09:47
flink-dist_2.10-1.3-SNAPSHOT.jar
-rw-r--r-- 1 robert robert 99K May 24 09:40
flink-python_2.10-1.3-SNAPSHOT.jar
-rw-r--r-- 1 robert robert 23M May 24 09:47
flink-shaded-hadoop2-uber-1.3-SNAPSHOT.jar
-rw-r--r-- 1 robert robert 479K Nov 17 2015 log4j-1.2.17.jar
-rw-r--r-- 1 robert robert 8.7K Nov 17 2015 slf4j-log4j12-1.7.7.jar
```
after the change, the flink dist file grows significantly:
```
-rw-r--r-- 1 robert robert 87M May 24 09:51
flink-dist_2.10-1.3-SNAPSHOT.jar
-rw-r--r-- 1 robert robert 99K May 24 09:40
flink-python_2.10-1.3-SNAPSHOT.jar
-rw-r--r-- 1 robert robert 23M May 24 09:47
flink-shaded-hadoop2-uber-1.3-SNAPSHOT.jar
-rw-r--r-- 1 robert robert 479K Nov 17 2015 log4j-1.2.17.jar
-rw-r--r-- 1 robert robert 8.7K Nov 17 2015 slf4j-log4j12-1.7.7.jar
```
I quickly opened the file and I found all `org.apache.hadoop` classes in
the dist again.
I'm against doing a "quick fix" before the release here.
> missing maven dependency on "flink-shaded-hadoop2-uber" in flink-dist
> ---------------------------------------------------------------------
>
> Key: FLINK-6654
> URL: https://issues.apache.org/jira/browse/FLINK-6654
> Project: Flink
> Issue Type: Bug
> Components: Build System
> Affects Versions: 1.3.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
> Fix For: 1.3.0
>
>
> Since applying FLINK-6514, flink-dist includes
> {{flink-shaded-hadoop2-uber-*.jar}} but without giving this dependency in its
> {{pom.xml}}. This may lead to concurrency issues during builds but also fails
> building the flink-dist module only (with dependencies) as in
> {code}
> mvn clean install -pl flink-dist -am
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
