[
https://issues.apache.org/jira/browse/FLINK-6137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022805#comment-16022805
]
ASF GitHub Bot commented on FLINK-6137:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3976#discussion_r118236599
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/NFAITCase.java
---
@@ -1896,21 +1898,21 @@ public boolean filter(Event value) throws Exception
{
List<List<Event>> resultingPatterns = feedNFA(inputEvents, nfa);
compareMaps(resultingPatterns, Lists.<List<Event>>newArrayList(
- Lists.newArrayList(ConsecutiveData.startEvent,
ConsecutiveData.middleEvent1, ConsecutiveData.middleEvent2,
ConsecutiveData.end),
- Lists.newArrayList(ConsecutiveData.startEvent,
ConsecutiveData.middleEvent1, ConsecutiveData.middleEvent3,
ConsecutiveData.end),
- Lists.newArrayList(ConsecutiveData.startEvent,
ConsecutiveData.end)
+ Lists.newArrayList(ConsecutiveData.START_EVENT,
ConsecutiveData.MIDDLE_EVENT_1, ConsecutiveData.MIDDLE_EVENT_2,
ConsecutiveData.END),
+ Lists.newArrayList(ConsecutiveData.START_EVENT,
ConsecutiveData.MIDDLE_EVENT_1, ConsecutiveData.MIDDLE_EVENT_3,
ConsecutiveData.END),
+ Lists.newArrayList(ConsecutiveData.START_EVENT,
ConsecutiveData.END)
));
}
/////////////////////////////// Consecutive
////////////////////////////////////////
private static class ConsecutiveData {
- static final Event startEvent = new Event(40, "c", 1.0);
- static final Event middleEvent1 = new Event(41, "a", 2.0);
- static final Event middleEvent2 = new Event(42, "a", 3.0);
- static final Event middleEvent3 = new Event(43, "a", 4.0);
- static final Event middleEvent4 = new Event(43, "a", 5.0);
- static final Event end = new Event(44, "b", 5.0);
+ static final Event START_EVENT = new Event(40, "c", 1.0);
--- End diff --
you can make these private, then you don't have to rename them.
> Activate strict checkstyle for flink-cep
> ----------------------------------------
>
> Key: FLINK-6137
> URL: https://issues.apache.org/jira/browse/FLINK-6137
> Project: Flink
> Issue Type: Sub-task
> Components: CEP
> Reporter: Dawid Wysakowicz
> Assignee: Dawid Wysakowicz
> Priority: Minor
>
> Add a custom checkstyle.xml for `flink-cep` library as in [FLINK-6107]
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
