[
https://issues.apache.org/jira/browse/FLINK-6653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025906#comment-16025906
]
ASF GitHub Bot commented on FLINK-6653:
---------------------------------------
GitHub user tony810430 opened a pull request:
https://github.com/apache/flink/pull/3994
[FLINK-6653] Avoid directly serializing AWS's Shard class in Kinesis
consumer's checkpoints
The proposal please refer to the comment on JIRA.
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [v] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [v] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tony810430/flink FLINK-6653
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3994.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3994
----
commit 9ebec3a7242cd225626a9e17bad4e315f9cbab53
Author: Tony Wei <[email protected]>
Date: 2017-05-25T02:39:22Z
[FLINK-6653] Avoid directly serializing AWS's Shard class in Kinesis
consumer's checkpoints
----
> Avoid directly serializing AWS's Shard class in Kinesis consumer's checkpoints
> ------------------------------------------------------------------------------
>
> Key: FLINK-6653
> URL: https://issues.apache.org/jira/browse/FLINK-6653
> Project: Flink
> Issue Type: Improvement
> Components: Kinesis Connector
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Wei-Che Wei
>
> Currently, the Kinesis consumer's checkpoints directly serialize AWS's
> {{Shard}} instances in checkpoints. This makes bumping AWS library versions
> hard, since any change to the {{Shard}} class by AWS will break checkpoint
> compatibility.
> We should either have custom serialization for {{KinesisStreamShard}}, or
> disintegrate the information in {{Shard}}. Ideally, it would be best to make
> {{KinesisStreamShard}} and {{SequenceNumber}} to be non-serializable, hence
> avoiding Java serialization in the checkpoints.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
