[ 
https://issues.apache.org/jira/browse/FLINK-6167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025931#comment-16025931
 ] 

Chesnay Schepler edited comment on FLINK-6167 at 5/26/17 7:33 AM:
------------------------------------------------------------------

They are actually still used, before the EG is passed to the MemoryArchivist 
they are being archived. This has the nice side effect of only retaining 
references that we actually need, independent of future additions..


was (Author: zentol):
They are actually still used, before the EG is passed to the MemoryArchivist 
they are being archived. This has the nice side effect of only retaining 
references that we actually need, independent of future changes..

> Consider removing ArchivedExecutionGraph classes
> ------------------------------------------------
>
>                 Key: FLINK-6167
>                 URL: https://issues.apache.org/jira/browse/FLINK-6167
>             Project: Flink
>          Issue Type: Improvement
>          Components: JobManager
>    Affects Versions: 1.3.0
>            Reporter: Chesnay Schepler
>            Priority: Minor
>
> The Archived* versions of the ExecutionGraph classes (ExecutionGraph, 
> ExecutionJobVertex, ExecutionVertex, Execution) were originally intended to 
> provide a serializable object that can be transferred to the History Server.
> The revised implementation of the history server however no longer requires 
> them.
> As such we could either remove them, or keep them for testing purposes 
> (instead of mocking) as they simplify the testing of the web-interface 
> handlers quite a lot, which would however require keeping the Access* 
> interfaces.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to