[ https://issues.apache.org/jira/browse/FLINK-6725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026972#comment-16026972 ]
ASF GitHub Bot commented on FLINK-6725: --------------------------------------- Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3993 The change itself is OK. However, I added a comment about breaking the API and the change itself to the corresponding JIRA issue. > make requiresOver as a contracted method in udagg > ------------------------------------------------- > > Key: FLINK-6725 > URL: https://issues.apache.org/jira/browse/FLINK-6725 > Project: Flink > Issue Type: Improvement > Components: Table API & SQL > Reporter: Shaoxuan Wang > Assignee: Shaoxuan Wang > > I realized requiresOver is defined in the udagg interface when I wrote up the > udagg doc. I would like to put requiresOver as a contract method. This makes > the entire udagg interface consistently and clean. -- This message was sent by Atlassian JIRA (v6.3.15#6346)