[
https://issues.apache.org/jira/browse/FLINK-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030643#comment-16030643
]
ASF GitHub Bot commented on FLINK-5488:
---------------------------------------
GitHub user zjureel opened a pull request:
https://github.com/apache/flink/pull/4022
[FLINK-5488] stop YarnClient before exception is thrown
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjureel/flink FLINK-5488
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4022.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4022
----
commit c8cd1be559e1da7f0c5978206897e8ac63480765
Author: zjureel <[email protected]>
Date: 2017-05-31T05:13:34Z
[FLINK-5488] stop YarnClient before exception is thrown
----
> yarnClient should be closed in AbstractYarnClusterDescriptor for error
> conditions
> ---------------------------------------------------------------------------------
>
> Key: FLINK-5488
> URL: https://issues.apache.org/jira/browse/FLINK-5488
> Project: Flink
> Issue Type: Bug
> Components: YARN
> Reporter: Ted Yu
> Assignee: Fang Yong
>
> Here is one example:
> {code}
> if(jobManagerMemoryMb > maxRes.getMemory() ) {
> failSessionDuringDeployment(yarnClient, yarnApplication);
> throw new YarnDeploymentException("The cluster does not have the
> requested resources for the JobManager available!\n"
> + "Maximum Memory: " + maxRes.getMemory() + "MB Requested: " +
> jobManagerMemoryMb + "MB. " + NOTE);
> }
> {code}
> yarnClient implements Closeable.
> It should be closed in situations where exception is thrown.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
