[ 
https://issues.apache.org/jira/browse/FLINK-6752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16031147#comment-16031147
 ] 

ASF GitHub Bot commented on FLINK-6752:
---------------------------------------

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/4027
  
    After looking into the remaining modules a bit i think we could safely 
merge a full checkstyle commit for all modules but flink-runtime, contrary to 
my previous comments in the JIRA. Core, java, optimizer and tests are actually 
rather stale in terms of modifications; we primarily add things to them which 
typically doesn't result in conflicts.
    
    For runtime I'm currently thinking of applying the full checkstyle one 
package at a time; there's way to many threads going on in there to globally 
introduce most rules at once; although there are some exceptions like adding an 
empty line before the package declaration.


> Activate strict checkstyle for flink-core
> -----------------------------------------
>
>                 Key: FLINK-6752
>                 URL: https://issues.apache.org/jira/browse/FLINK-6752
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.4.0
>
>
> Long term issue for incrementally introducing the strict checkstyle to 
> flink-core.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to