Github user alpinegizmo commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4013#discussion_r119360977
  
    --- Diff: docs/dev/tableApi.md ---
    @@ -61,21 +45,38 @@ The following dependency must be added to your project 
in order to use the Table
     </dependency>
     {% endhighlight %}
     
    -*Note: The Table API is currently not part of the binary distribution. See 
linking with it for cluster execution [here]({{ site.baseurl 
}}/dev/linking.html).*
    +In addition, you need to add a dependency for either Flink's Scala batch 
or streaming API. For a batch query you need to add:
    +
    +{% highlight xml %}
    +<dependency>
    +  <groupId>org.apache.flink</groupId>
    +  <artifactId>flink-scala{{ site.scala_version_suffix }}</artifactId>
    +  <version>{{site.version }}</version>
    +</dependency>
    +{% endhighlight %}
    +
    +For a streaming query you need to add:
    +
    +{% highlight xml %}
    +<dependency>
    +  <groupId>org.apache.flink</groupId>
    +  <artifactId>flink-streaming-scala{{ site.scala_version_suffix 
}}</artifactId>
    +  <version>{{site.version }}</version>
    +</dependency>
    +{% endhighlight %}
     
    -**TODO: Rework and add:**
    -* Project dependencies (flink-table + flink-scala or flink-streaming-scala)
    -* Copy `./opt/flink-table.jar` to `./lib`
    +**Note:** Due to an issue in Apache Calcite, which prevents the user 
classloaders from being garbage-collected, we do *not* recommend to build a 
fat-jar the includes the `flink-table` dependency. Instead, we recommend to 
configure Flink to include the `flink-table` dependency in the system 
classloader. This can be done by copying the `flink-table.jar` file from the 
`./opt` folder to the `./lib` folder. See [these instructions]({{ site.baseurl 
}}/dev/linking.html) for further details.
    --- End diff --
    
    ... we do *not* recommend building a fat-jar that includes the ...
    
    Instead, we recommend configuring Flink ...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to