GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/4042

    [FLINK-6792] [mvn] Move maven-checkstyle-plugin before maven-shade-plugin 
definition in pom.xml

    Somehow appending the maven-checkstyle-plugin at the end of the pom.xml 
changed the order
    of the maven-assembly-plugin and the maven-shade-plugin in the package 
phase. This breaks
    things since the shade plugin has to run before the assembly plugin to 
build the fat-jar.
    Specifying the checkstyle-plugin before the maven-shade-plugin resolves the 
issue.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink fixDistCheckstyleProblem

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4042.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4042
    
----
commit 3c53c3a08d70a00d96d2a510807951d08a4de302
Author: Till Rohrmann <[email protected]>
Date:   2017-06-01T12:12:49Z

    [FLINK-6792] [mvn] Move maven-checkstyle-plugin before maven-shade-plugin 
definition in pom.xml
    
    Somehow appending the maven-checkstyle-plugin at the end of the pom.xml 
changed the order
    of the maven-assembly-plugin and the maven-shade-plugin in the package 
phase. This breaks
    things since the shade plugin has to run before the assembly plugin to 
build the fat-jar.
    Specifying the checkstyle-plugin before the maven-shade-plugin resolves the 
issue.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to