[
https://issues.apache.org/jira/browse/FLINK-6221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16034365#comment-16034365
]
ASF GitHub Bot commented on FLINK-6221:
---------------------------------------
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3833
I think it is intended. The majority of tests can be (and are) commented
with "Tests for the {@link <classToTest>}.", which is totally OK because it
tells us that this is the general test battery for that class and not something
else. These are also easy to add so there's not a real overhead in doing so.
But this doesn't apply to all of them; and you only really notice the
missing javadoc when you stumble on a test and you spend 10 minutes trying to
figure out what it is doing because the method names aren't helping at all.
The widely-accepted notion that the name of a class and test method are
supposed to be enough documentation for test is quite questionable IMO; and by
enforcing a javadoc on the class we give a little nudge to make the developer
hopefully think about whether something needs to be documented or not.
> Add Prometheus support to metrics
> ---------------------------------
>
> Key: FLINK-6221
> URL: https://issues.apache.org/jira/browse/FLINK-6221
> Project: Flink
> Issue Type: Improvement
> Components: Metrics
> Affects Versions: 1.2.0
> Reporter: Joshua Griffith
> Assignee: Maximilian Bode
> Priority: Minor
>
> [Prometheus|https://prometheus.io/] is becoming popular for metrics and
> alerting. It's possible to use
> [statsd-exporter|https://github.com/prometheus/statsd_exporter] to load Flink
> metrics into Prometheus but it would be far easier if Flink supported
> Promethus as a metrics reporter. A [dropwizard
> client|https://github.com/prometheus/client_java/tree/master/simpleclient_dropwizard]
> exists that could be integrated into the existing metrics system.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
