[
https://issues.apache.org/jira/browse/FLINK-6749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16034980#comment-16034980
]
ASF GitHub Bot commented on FLINK-6749:
---------------------------------------
Github user alpinegizmo commented on a diff in the pull request:
https://github.com/apache/flink/pull/4046#discussion_r119896766
--- Diff: docs/dev/table/sql.md ---
@@ -22,20 +22,22 @@ specific language governing permissions and limitations
under the License.
-->
-SQL queries are specified using the `sql()` method of the
`TableEnvironment`. The method returns the result of the SQL query as a `Table`
which can be converted into a `DataSet` or `DataStream`, used in subsequent
Table API queries, or written to a `TableSink` (see [Writing Tables to External
Sinks](#writing-tables-to-external-sinks)). SQL and Table API queries can
seamlessly mixed and are holistically optimized and translated into a single
DataStream or DataSet program.
+Flink supports specifying DataStream or DataSet programs with SQL queries
using the `sql()` method of the `TableEnvironment`. The method returns the
result of the SQL query as a `Table`. A `Table` can be used in the subsequent
SQL / Table API queries, be converted into a `DataSet` or `DataStream`, used in
subsequent Table API queries or written to a `TableSink` (see [Writing Tables
to External Sinks](common.html#emit-to-a-tablesink)). SQL and Table API queries
can seamlessly mixed and are holistically optimized and translated into a
single program.
-A `Table`, `DataSet`, `DataStream`, or external `TableSource` must be
registered in the `TableEnvironment` in order to be accessible by a SQL query
(see [Registering Tables](#registering-tables)). For convenience
`Table.toString()` will automatically register an unique table name under the
`Table`'s `TableEnvironment` and return the table name. So it allows to call
SQL directly on tables in a string concatenation (see examples below).
+To access the data in the SQL queries, users must register data sources,
including `Table`, `DataSet`, `DataStream` or external `TableSource`, in the
`TableEnvironment` (see [Registering
Tables](common.html#register-a-table-in-the-catalog)). Alternatively, users can
also register external catalogs in the `TableEnvironment` to specify the
location of the data sources.
--- End diff --
This reads a bit awkwardly. How about this?
Before using data in a SQL query, the data source(s) must first be
registered in the `TableEnvironment` (see [Registering
Tables](common.html#register-a-table-in-the-catalog)). Possible data sources
include `Table`s, `DataSet`s, `DataStream`s, and external `TableSource`s.
Alternatively, ...
> Table API / SQL Docs: SQL Page
> ------------------------------
>
> Key: FLINK-6749
> URL: https://issues.apache.org/jira/browse/FLINK-6749
> Project: Flink
> Issue Type: Sub-task
> Components: Documentation, Table API & SQL
> Affects Versions: 1.3.0
> Reporter: Fabian Hueske
> Assignee: Haohui Mai
>
> Update and refine {{./docs/dev/table/sql.md}} in feature branch
> https://github.com/apache/flink/tree/tableDocs
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
