[ 
https://issues.apache.org/jira/browse/FLINK-6816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035136#comment-16035136
 ] 

ASF GitHub Bot commented on FLINK-6816:
---------------------------------------

Github user sunjincheng121 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4050#discussion_r119915689
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedRangeOver.scala
 ---
    @@ -62,8 +62,8 @@ class ProcTimeBoundedRangeOver(
       private var function: GeneratedAggregations = _
     
       override def open(config: Configuration) {
    -    LOG.debug(s"Compiling AggregateHelper: $genAggregations.name \n\n " +
    -                s"Code:\n$genAggregations.code")
    +    LOG.debug(s"Compiling AggregateHelper: ${genAggregations.name} \n\n " +
    --- End diff --
    
    I think we supported remove the " ", i.e.: 
    `${genAggregations.name} \n\n "` -> `${genAggregations.name} \n\n"`
    If we do this change, the log print info as follows:
    FROM 
    ```
    Compiling AggregateHelper: MinMaxAggregateHelper 
    
       Code:
    GeneratedAggregationsFunction(MinMaxAggregateHelper,
    ```
    TO
    ```
    Compiling AggregateHelper: MinMaxAggregateHelper 
    
    Code:
    GeneratedAggregationsFunction(MinMaxAggregateHelper,
    ```


> Fix wrong usage of Scala string interpolation in Table API
> ----------------------------------------------------------
>
>                 Key: FLINK-6816
>                 URL: https://issues.apache.org/jira/browse/FLINK-6816
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>            Reporter: Jark Wu
>            Assignee: Jark Wu
>            Priority: Minor
>             Fix For: 1.4.0
>
>
> This issue is to fix some wrong usage of  Scala string interpolation, such as 
> missing the "s" prefix .



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to