[ 
https://issues.apache.org/jira/browse/FLINK-6830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16038918#comment-16038918
 ] 

ASF GitHub Bot commented on FLINK-6830:
---------------------------------------

Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4059#discussion_r120365906
  
    --- Diff: 
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperatorMigrationTest.java
 ---
    @@ -149,9 +169,16 @@ public void 
testRestoreSessionWindowsWithCountTrigger() throws Exception {
                                new 
KeyedOneInputStreamOperatorTestHarness<>(operator, new TupleKeySelector(), 
BasicTypeInfo.STRING_TYPE_INFO);
     
                testHarness.setup();
    -           testHarness.initializeState(
    -                           OperatorSnapshotUtil.readStateHandle(
    -                                           
OperatorSnapshotUtil.getResourceFilename("win-op-migration-test-session-with-stateful-trigger-flink1.2-snapshot")));
    +
    +           String savepointFile = 
"win-op-migration-test-session-with-stateful-trigger-flink" + 
testMigrateVersion + "-snapshot";
    +           if (testMigrateVersion.equals("1.1")) {
    --- End diff --
    
    That makes sense! I'll add the method to some `MigrationTestUtil` perhaps.


> Add ITTests for savepoint migration from 1.3
> --------------------------------------------
>
>                 Key: FLINK-6830
>                 URL: https://issues.apache.org/jira/browse/FLINK-6830
>             Project: Flink
>          Issue Type: Test
>          Components: State Backends, Checkpointing
>    Affects Versions: 1.3.0
>            Reporter: Tzu-Li (Gordon) Tai
>            Assignee: Tzu-Li (Gordon) Tai
>             Fix For: 1.3.1
>
>
> Already with FLINK-6763 and FLINK-6764 we'll need to change the serialization 
> formats between 1.3.0 and 1.3.x.
> We probably should add the stateful job migration ITCases for restoring from 
> Flink 1.3.x now.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to