[
https://issues.apache.org/jira/browse/FLINK-6823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16039310#comment-16039310
]
ASF GitHub Bot commented on FLINK-6823:
---------------------------------------
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4068#discussion_r120427634
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/broadcast/BroadcastVariableManager.java
---
@@ -18,34 +18,42 @@
package org.apache.flink.runtime.broadcast;
-import java.io.IOException;
-import java.util.Map;
-import java.util.concurrent.ConcurrentHashMap;
-
import org.apache.flink.api.common.typeutils.TypeSerializerFactory;
import org.apache.flink.runtime.io.network.api.reader.MutableReader;
import org.apache.flink.runtime.operators.BatchTask;
+import java.io.IOException;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * The BroadcastVariableManager is used to manage the materialization of
broadcast variables. References to materialized
+ * broadcast variables are cached and shared between parallel subtasks. A
reference count is maintained to track whether
+ * a the materialization may be cleaned up.
+ */
public class BroadcastVariableManager {
-
+
private final ConcurrentHashMap<BroadcastVariableKey,
BroadcastVariableMaterialization<?, ?>> variables =
new
ConcurrentHashMap<BroadcastVariableKey, BroadcastVariableMaterialization<?,
?>>(16);
-
+
//
--------------------------------------------------------------------------------------------
-
+
+ /**
+ * Materializes the broadcast variable for the given name, scoped to
the given task and it's iteration superstep. An
--- End diff --
`it's` -> `its`
> Activate checkstyle for runtime/broadcast
> -----------------------------------------
>
> Key: FLINK-6823
> URL: https://issues.apache.org/jira/browse/FLINK-6823
> Project: Flink
> Issue Type: Improvement
> Components: Local Runtime
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Trivial
> Fix For: 1.4.0
>
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)