[ 
https://issues.apache.org/jira/browse/FLINK-6511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16040017#comment-16040017
 ] 

Fang Yong commented on FLINK-6511:
----------------------------------

Thank you for your reply [~till.rohrmann], It's sound good! I noted that all 
the methods in {{JobClient}} are static, in my mind there may be some changes 
in JobClient as follows:
1. Create non static methods that are consistent with the current static ones 
in {{JobClient}}
2. Add {{close}} method in {{JobClient}}
3. Create instance of {{BlobCache}} in {{JobClient}}, and close it when the 
{{JobClient}} is closed

What do you think of it? Looking forward to hearing your suggestion, thanks :)

> JobClient does not properly clean up BlobCache resources
> --------------------------------------------------------
>
>                 Key: FLINK-6511
>                 URL: https://issues.apache.org/jira/browse/FLINK-6511
>             Project: Flink
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 1.3.0
>            Reporter: Till Rohrmann
>            Assignee: Fang Yong
>
> The {{JobClient}} creates a {{BlobCache}} to download user code jars from the 
> {{BlobServer}} when trying to retrieve the user code class loader. This 
> {{BlobCache}} won't be properly closed, though. I think it would be better to 
> instantiate a {{BlobCache}} in the {{JobClient}} and close once the 
> {{JobClient}} is being closed. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to