Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4103#discussion_r121386625
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompatibilityResult.java
---
@@ -60,10 +62,10 @@
*
* @return a result that signals migration is necessary, also providing
a convert deserializer.
*/
- public static <T> CompatibilityResult<T>
requiresMigration(TypeDeserializer<T> convertDeserializer) {
+ public static <T> CompatibilityResult<T> requiresMigration(@Nonnull
TypeDeserializer<T> convertDeserializer) {
Preconditions.checkNotNull(convertDeserializer, "Convert
deserializer cannot be null.");
- return new CompatibilityResult<>(true,
Preconditions.checkNotNull(convertDeserializer));
+ return new CompatibilityResult<>(true, convertDeserializer);
--- End diff --
Does `@Nonnull` always ensure that the argument is not null? We could
simply keep the additional `Preconditions` check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
