[
https://issues.apache.org/jira/browse/FLINK-6901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16047558#comment-16047558
]
ASF GitHub Bot commented on FLINK-6901:
---------------------------------------
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4112
Looks like the same problem we have in flink-core also exists in
flink-runtime, some braces are missing...
```
[INFO] There are 10 errors reported by Checkstyle 6.19 with
/tools/maven/checkstyle.xml ruleset.
[ERROR]
src/main/java/org/apache/flink/runtime/broadcast/BroadcastVariableMaterialization.java:[134]
(blocks) NeedBraces: 'while' construct must use '{}'s.
[ERROR]
src/main/java/org/apache/flink/runtime/io/network/netty/NettyBufferPool.java:[25,1]
(imports) IllegalImport: Import from illegal package -
io.netty.util.internal.PlatformDependent.
[ERROR]
src/main/java/org/apache/flink/runtime/iterative/task/AbstractIterativeTask.java:[247]
(blocks) NeedBraces: 'while' construct must use '{}'s.
[ERROR]
src/main/java/org/apache/flink/runtime/operators/AbstractCachedBuildSideJoinDriver.java:[176]
(blocks) NeedBraces: 'while' construct must use '{}'s.
[ERROR]
src/main/java/org/apache/flink/runtime/operators/AbstractOuterJoinDriver.java:[160]
(blocks) NeedBraces: 'while' construct must use '{}'s.
[ERROR]
src/main/java/org/apache/flink/runtime/operators/JoinDriver.java:[222] (blocks)
NeedBraces: 'while' construct must use '{}'s.
[ERROR]
src/main/java/org/apache/flink/runtime/operators/sort/AbstractMergeInnerJoinIterator.java:[68]
(blocks) NeedBraces: 'while' construct must use '{}'s.
[ERROR]
src/main/java/org/apache/flink/runtime/operators/sort/AbstractMergeInnerJoinIterator.java:[69]
(blocks) NeedBraces: 'while' construct must use '{}'s.
[ERROR]
src/main/java/org/apache/flink/runtime/operators/sort/AbstractMergeOuterJoinIterator.java:[92]
(blocks) NeedBraces: 'while' construct must use '{}'s.
[ERROR]
src/main/java/org/apache/flink/runtime/operators/sort/AbstractMergeOuterJoinIterator.java:[103]
(blocks) NeedBraces: 'while' construct must use '{}'s.
```
> Flip checkstyle configuration files
> -----------------------------------
>
> Key: FLINK-6901
> URL: https://issues.apache.org/jira/browse/FLINK-6901
> Project: Flink
> Issue Type: Improvement
> Components: Checkstyle
> Affects Versions: 1.4.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
>
> We currently have 2 checkstyle files, {{checkstyle.xml}} as the basic
> version, and {{strict-checkstyle.xml}} as a heavily expanded version that is
> applied to most existing modules (see FLINK-6698).
> [~greghogan] suggested to flip the checkstyle while reviewing this PR
> https://github.com/apache/flink/pull/4086, given that the strict checkstyle
> is supposed to subsume the existing checkstyle in the long-term.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
