[
https://issues.apache.org/jira/browse/FLINK-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16052768#comment-16052768
]
ASF GitHub Bot commented on FLINK-6933:
---------------------------------------
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/4132#discussion_r122564524
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java
---
@@ -348,7 +348,7 @@ long getWindowTime() {
return copyOfSink;
}
- private void addStopStates(final State<T> state) {
+ private void addStopState(final State<T> state) {
--- End diff --
I feel it should stay as `addStopStates` as it can add more than one state.
> Refactor NFACompiler to reduce code duplication
> -----------------------------------------------
>
> Key: FLINK-6933
> URL: https://issues.apache.org/jira/browse/FLINK-6933
> Project: Flink
> Issue Type: Sub-task
> Components: CEP
> Reporter: Dian Fu
> Assignee: Dian Fu
>
> I find that part of the code in NFACompiler is duplicate, this JIRA tries to
> eliminate the code duplication.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
