[
https://issues.apache.org/jira/browse/FLINK-6498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053839#comment-16053839
]
ASF GitHub Bot commented on FLINK-6498:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4123#discussion_r122680550
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -1594,51 +1640,103 @@
// --------------------------- ZooKeeper
----------------------------------
+ /** @deprecated in favor of {@link
HighAvailabilityOptions#HA_ZOOKEEPER_ROOT}. */
+ @Deprecated
public static final String DEFAULT_ZOOKEEPER_DIR_KEY = "/flink";
+ /** @deprecated in favor of {@link
HighAvailabilityOptions#HA_ZOOKEEPER_NAMESPACE}. */
+ @Deprecated
public static final String DEFAULT_ZOOKEEPER_NAMESPACE_KEY = "/default";
+ /** @deprecated in favor of {@link
HighAvailabilityOptions#HA_ZOOKEEPER_LATCH_PATH}. */
+ @Deprecated
public static final String DEFAULT_ZOOKEEPER_LATCH_PATH =
"/leaderlatch";
+ /** @deprecated in favor of {@link
HighAvailabilityOptions#HA_ZOOKEEPER_LEADER_PATH}. */
+ @Deprecated
public static final String DEFAULT_ZOOKEEPER_LEADER_PATH = "/leader";
+ /** @deprecated in favor of {@link
HighAvailabilityOptions#HA_ZOOKEEPER_JOBGRAPHS_PATH}. */
+ @Deprecated
public static final String DEFAULT_ZOOKEEPER_JOBGRAPHS_PATH =
"/jobgraphs";
+ /** @deprecated in favor of {@link
HighAvailabilityOptions#HA_ZOOKEEPER_CHECKPOINTS_PATH}. */
+ @Deprecated
public static final String DEFAULT_ZOOKEEPER_CHECKPOINTS_PATH =
"/checkpoints";
+ /** @deprecated in favor of {@link
HighAvailabilityOptions#HA_ZOOKEEPER_CHECKPOINT_COUNTER_PATH} */
+ @Deprecated
public static final String DEFAULT_ZOOKEEPER_CHECKPOINT_COUNTER_PATH =
"/checkpoint-counter";
+ /** @deprecated in favor of {@link
HighAvailabilityOptions#HA_ZOOKEEPER_MESOS_WORKERS_PATH}. */
+ @Deprecated
public static final String DEFAULT_ZOOKEEPER_MESOS_WORKERS_PATH =
"/mesos-workers";
+ /** @deprecated in favor of {@link
HighAvailabilityOptions#ZOOKEEPER_SESSION_TIMEOUT}. */
+ @Deprecated
public static final int DEFAULT_ZOOKEEPER_SESSION_TIMEOUT = 60000;
+ /** @deprecated in favor of {@link
HighAvailabilityOptions#ZOOKEEPER_CONNECTION_TIMEOUT}. */
+ @Deprecated
public static final int DEFAULT_ZOOKEEPER_CONNECTION_TIMEOUT = 15000;
+ /** @deprecated in favor of {@link
HighAvailabilityOptions#ZOOKEEPER_RETRY_WAIT}. */
+ @Deprecated
public static final int DEFAULT_ZOOKEEPER_RETRY_WAIT = 5000;
+ /** @deprecated in favor of {@link
HighAvailabilityOptions#ZOOKEEPER_MAX_RETRY_ATTEMPTS}. */
+ @Deprecated
public static final int DEFAULT_ZOOKEEPER_MAX_RETRY_ATTEMPTS = 3;
// - Defaults for required ZooKeeper configuration keys
-------------------
- /** ZooKeeper default client port. */
+ /**
+ * ZooKeeper default client port.
+ * @deprecated in favor of {@code
FlinkZookeeperQuorumPeer#DEFAULT_ZOOKEEPER_CLIENT_PORT}.
+ */
+ @Deprecated
public static final int DEFAULT_ZOOKEEPER_CLIENT_PORT = 2181;
- /** ZooKeeper default init limit. */
+ /**
+ * ZooKeeper default init limit.
+ * @deprecated in favor of {@code
FlinkZookeeperQuorumPeer#DEFAULT_ZOOKEEPER_INIT_LIMIT}.
+ */
+ @Deprecated
public static final int DEFAULT_ZOOKEEPER_INIT_LIMIT = 10;
- /** ZooKeeper default sync limit. */
+ /**
+ * ZooKeeper default sync limit.
+ * @deprecated in favor of {@code
FlinkZookeeperQuorumPeer#DEFAULT_ZOOKEEPER_SYNC_LIMIT}.
+ */
+ @Deprecated
public static final int DEFAULT_ZOOKEEPER_SYNC_LIMIT = 5;
- /** ZooKeeper default peer port. */
+ /**
+ * ZooKeeper default peer port.
+ * @deprecated in favor of {@code
FlinkZookeeperQuorumPeer#DEFAULT_ZOOKEEPER_PEER_PORT}.
+ */
+ @Deprecated
public static final int DEFAULT_ZOOKEEPER_PEER_PORT = 2888;
- /** ZooKeeper default leader port. */
+ /**
+ * ZooKeeper default leader port.
+ * @deprecated in favor of {@code
FlinkZookeeperQuorumPeer#DEFAULT_ZOOKEEPER_LEADER_PORT}.
+ */
+ @Deprecated
public static final int DEFAULT_ZOOKEEPER_LEADER_PORT = 3888;
- /** Defaults for ZK client security **/
+ /**
+ * Defaults for ZK client security.
+ * @deprecated in favor of {@link
SecurityOptions#ZOOKEEPER_SASL_DISABLE}.
+ */
+ @Deprecated
public static final boolean DEFAULT_ZOOKEEPER_SASL_DISABLE = true;
- /** ACL options supported "creator" or "open" */
+ /**
+ * ACL options supported "creator" or "open".
+ * @deprecated in favor of {@link
HighAvailabilityOptions#HA_ZOOKEEPER_CLIENT_ACL}.
--- End diff --
remove `HA_` prefix
> Migrate Zookeeper configuration options
> ---------------------------------------
>
> Key: FLINK-6498
> URL: https://issues.apache.org/jira/browse/FLINK-6498
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
> Reporter: Chesnay Schepler
> Assignee: Fang Yong
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
