Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/729#discussion_r31530742
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/operators/SingleInputUdfOperator.java
---
@@ -54,8 +54,11 @@
private Map<String, DataSet<?>> broadcastVariables;
+ // NOTE: only set this variable via setSemanticProperties()
--- End diff --
I think this refactoring is quite fragile. The semantic properties utility
is not returning an empty properties object, but null and you take care of
setting it correctly here depending on whether the forwarded fields have been
set manually or not.
If optimize is enabled and there are manual annotations, they will be
overriden. I am wondering if it is better to have manual annotations trump
optimizer annotations. What's your opinion on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
