Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/3844#discussion_r122718852
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/state/operator/restore/keyed/KeyedJob.java
---
@@ -98,10 +98,9 @@ public static void main(String[] args) throws Exception {
.map(new StatefulStringStoringMap(mode, "first"))
.setParallelism(4);
- // TODO: re-enable this when generating the actual 1.2 savepoint
- //if (mode == ExecutionMode.MIGRATE || mode ==
ExecutionMode.RESTORE) {
- map.uid("first");
- //}
+ if (mode == ExecutionMode.MIGRATE || mode ==
ExecutionMode.RESTORE) {
--- End diff --
I somehow don't like it that is not explained in the commit message what
has actually changed/why was this change required at all. Especially since you
have not changed anything else in the code, it is difficult to understand that.
If nothing else has changed, why do we need this `if (...)`? If something has
changed, shouldn't it be covered by some test?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
