[
https://issues.apache.org/jira/browse/FLINK-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055441#comment-16055441
]
ASF GitHub Bot commented on FLINK-6786:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4034#discussion_r122925221
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/metrics/dump/QueryScopeInfoTest.java
---
@@ -20,58 +20,140 @@
import org.junit.Test;
-import static
org.apache.flink.runtime.metrics.dump.QueryScopeInfo.INFO_CATEGORY_JM;
--- End diff --
Whether to use static imports or not is currently rather undefined in Flink.
In this case i would remove the static import to make it very clear in the
test that we're comparing to a constant that is defined outside the test.
> Remove duplicate QueryScopeInfoTest
> -----------------------------------
>
> Key: FLINK-6786
> URL: https://issues.apache.org/jira/browse/FLINK-6786
> Project: Flink
> Issue Type: Improvement
> Components: Metrics, Tests
> Affects Versions: 1.4.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Fix For: 1.4.0
>
>
> The {{QueryScopeInfoTest}} exists twice in {{runtime/metrics}}, under
> {{groups/}} and {{dump/}}.
> These should be merged together.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
