[
https://issues.apache.org/jira/browse/FLINK-6008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055456#comment-16055456
]
ASF GitHub Bot commented on FLINK-6008:
---------------------------------------
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4146
[FLINK-6008] collection of BlobServer improvements
This PR is a light-weight version of #3512 that only includes the
improvements and can serve as a base for FLIP-19. It improves the following
things around the `BlobServer`/`BlobCache`:
* replace config options in `config.md` with non-deprecated ones, e.g.
`high-availability.cluster-id` and `high-availability.storageDir`
* do not fail the `BlobServer` when a delete operation fails
* add more unit tests
* general code style and docs improvements, like using
`Preconditions.checkArgument`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NicoK/flink flink-6008b
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4146.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4146
----
commit ce719ee39fbbca7b7828c17d9792fc87d37450c7
Author: Nico Kruber <[email protected]>
Date: 2017-01-06T17:42:58Z
[FLINK-6008][docs] update some config options to the new, non-deprecated
ones
commit 9efa8808e46adc1253f52a6a8cec6d3b4d29fee3
Author: Nico Kruber <[email protected]>
Date: 2016-12-20T15:49:57Z
[FLINK-6008][docs] minor improvements in the BlobService docs
commit ca3d533b0affa645ec93d40de378dadc829bbfe5
Author: Nico Kruber <[email protected]>
Date: 2016-12-20T17:27:13Z
[FLINK-6008] refactor BlobCache#getURL() for cleaner code
commit 0eededeb36dd833835753def7f4bb27c9d5fb67e
Author: Nico Kruber <[email protected]>
Date: 2017-03-09T17:14:02Z
[FLINK-6008] use Preconditions.checkArgument in BlobClient
commit 6249041a9db2b39ddf54e79a1aed5e7706e739c7
Author: Nico Kruber <[email protected]>
Date: 2016-12-21T15:23:29Z
[FLINK-6008] do not fail the BlobServer if delete fails
also extend the delete tests and remove one code duplication
commit e681239a538547f752d65358db1ebd2ba312b33c
Author: Nico Kruber <[email protected]>
Date: 2017-03-17T15:21:40Z
[FLINK-6008] fix concurrent job directory creation
also add according unit tests
commit 20beae2dbc91859e2ec724b35b20536dcd11fe90
Author: Nico Kruber <[email protected]>
Date: 2017-04-18T14:37:37Z
[FLINK-6008] some comments about BlobLibraryCacheManager cleanup
commit 8a33517fe6eb2fa932ab17cb0d82a3fa8d7b8d0b
Author: Nico Kruber <[email protected]>
Date: 2017-04-19T13:39:03Z
[hotfix] minor typos
commit 23889866ac21494fc4af90905ab1518cbe897118
Author: Nico Kruber <[email protected]>
Date: 2017-04-19T14:10:16Z
[FLINK-6008] further cleanup tests for BlobLibraryCacheManager
commit 01b1a245528c264a6061ed3a48b24c5a207369f6
Author: Nico Kruber <[email protected]>
Date: 2017-06-14T16:01:47Z
[FLINK-6008] do not guard a delete() call with a check for existence
----
> collection of BlobServer improvements
> -------------------------------------
>
> Key: FLINK-6008
> URL: https://issues.apache.org/jira/browse/FLINK-6008
> Project: Flink
> Issue Type: Improvement
> Components: Network
> Affects Versions: 1.3.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
>
> The following things should be improved around the BlobServer/BlobCache:
> * update config uptions with non-deprecated ones, e.g.
> {{high-availability.cluster-id}} and {{high-availability.storageDir}}
> * promote {{BlobStore#deleteAll(JobID)}} to the {{BlobService}}
> * extend the {{BlobService}} to work with {{NAME_ADDRESSABLE}} blobs
> (prepares FLINK-4399]
> * remove {{NAME_ADDRESSABLE}} blobs after job/task termination
> * do not fail the {{BlobServer}} when a delete operation fails
> * code style, like using {{Preconditions.checkArgument}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
