[
https://issues.apache.org/jira/browse/FLINK-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059396#comment-16059396
]
ASF GitHub Bot commented on FLINK-6785:
---------------------------------------
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4035
change looks good but fails the new checkstyle rules:
```
[INFO] There are 4 errors reported by Checkstyle 6.19 with
/tools/maven/strict-checkstyle.xml ruleset.
[ERROR]
src/test/java/org/apache/flink/runtime/metrics/MetricRegistryTest.java:[256]
(whitespace) EmptyLineSeparator: There is more than 1 empty line one after
another.
[ERROR]
src/test/java/org/apache/flink/runtime/metrics/MetricRegistryTest.java:[259]
(regexp) RegexpSingleline: Trailing whitespace
[ERROR]
src/test/java/org/apache/flink/runtime/metrics/MetricRegistryTest.java:[265]
(whitespace) EmptyLineSeparator: There is more than 1 empty line one after
another.
[ERROR]
src/test/java/org/apache/flink/runtime/metrics/MetricRegistryTest.java:[278]
(regexp) RegexpSingleline: Trailing whitespace
```
> Ineffective checks in MetricRegistryTest
> ----------------------------------------
>
> Key: FLINK-6785
> URL: https://issues.apache.org/jira/browse/FLINK-6785
> Project: Flink
> Issue Type: Bug
> Components: Metrics, Tests
> Affects Versions: 1.4.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
>
> Several tests in {{MetricRegistryTest}} have reporters doing assertions. By
> design exceptions from reporters are however catched and logged, and thus
> can't fail the test.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
