[
https://issues.apache.org/jira/browse/FLINK-6887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16060581#comment-16060581
]
ASF GitHub Bot commented on FLINK-6887:
---------------------------------------
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/4171
[FLINK-6887] [table] Split up CodeGenerator into several specific
CodeGenerator
Currently, the `CodeGenerator` is very huge and a bit difficult to
maintain. This PR splits it up into several specific `XXXCodeGenerator`.
Including `FunctionCodeGenerator`, `AggregationCodeGenerator`,
`CollectorCodeGenerator`, `InputFormatCodeGenerator`, and maybe
`CEPCodeGenerator` will be added in the future.
This may influence many other PRs, so I would like it to be reviewed ASAP.
@fhueske @twalthr
Thanks,
Jark Wu
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wuchong/flink codegen
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4171.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4171
----
commit 7ddb33b361cfe2f91c6228c518f02395420a16e6
Author: Jark Wu <[email protected]>
Date: 2017-06-23T08:29:20Z
[FLINK-6887] [table] Split up CodeGenerator into several specific
CodeGenerator
----
> Split up CodeGenerator into several specific CodeGenerator
> ----------------------------------------------------------
>
> Key: FLINK-6887
> URL: https://issues.apache.org/jira/browse/FLINK-6887
> Project: Flink
> Issue Type: Task
> Components: Table API & SQL
> Reporter: Jark Wu
> Assignee: Jark Wu
> Fix For: 1.4.0
>
>
> Currently, the {{CodeGenerator}} is very huge and a bit difficult to
> maintain. I suggest to split it up into several specific {{XXXCodeGenerator}}.
> For example, create {{AggregationFunctionCodeGenerator}} class and make it
> extend to {{CodeGenerator}} and move the {{def generateAggregations(...)}}
> method to it. The same as {{TableFunctionCollectorCodeGenerator}} and
> {{InputFormatCodeGenerator}}.
> What do you think? [~fhueske], [~twalthr], [~sunjincheng121]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
