[ 
https://issues.apache.org/jira/browse/FLINK-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062865#comment-16062865
 ] 

ASF GitHub Bot commented on FLINK-6965:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4160#discussion_r123971846
  
    --- Diff: tools/travis_mvn_watchdog.sh ---
    @@ -182,6 +182,13 @@ check_shaded_artifacts() {
                exit 1
        fi
     
    +   SNAPPY=`cat allClasses | grep '^org/xerial/snappy' | wc -l`
    +   if [ AVRO == "0" ]; then
    --- End diff --
    
    yes! nice catch...


> Avro is missing snappy dependency
> ---------------------------------
>
>                 Key: FLINK-6965
>                 URL: https://issues.apache.org/jira/browse/FLINK-6965
>             Project: Flink
>          Issue Type: Bug
>          Components: Type Serialization System
>    Affects Versions: 1.3.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Blocker
>             Fix For: 1.3.2
>
>
> The shading rework made before 1.3 removed a snappy dependency that was 
> accidentally pulled in through hadoop. This is technically alright, until 
> class-loaders rear their ugly heads.
> Our kafka connector can read avro records, which may or may not require 
> snappy. Usually this _should_ be solvable by including the snappy dependency 
> in the user-jar if necessary, however since the kafka connector loads classes 
> that it requires using the system class loader this doesn't work.
> As such we have to add a separate snappy dependency to flink-core.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to