[
https://issues.apache.org/jira/browse/FLINK-6388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063270#comment-16063270
]
ASF GitHub Bot commented on FLINK-6388:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3783#discussion_r124037411
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GeneratedAggregations.scala
---
@@ -20,16 +20,22 @@ package org.apache.flink.table.runtime.aggregate
import org.apache.flink.api.common.functions.Function
import org.apache.flink.types.Row
+import org.apache.flink.api.common.functions.RuntimeContext
/**
* Base class for code-generated aggregations.
*/
abstract class GeneratedAggregations extends Function {
+
+ /**
+ * Initialize the state for the distinct aggregation check
+ *
+ * @param ctx the runtime context to retrieve and initialize the
distinct states
+ */
+ def initialize(ctx: RuntimeContext)
/**
- * Sets the results of the aggregations (partial or final) to the
output row.
--- End diff --
Why would you like to change this comment?
> Add support for DISTINCT into Code Generated Aggregations
> ---------------------------------------------------------
>
> Key: FLINK-6388
> URL: https://issues.apache.org/jira/browse/FLINK-6388
> Project: Flink
> Issue Type: Sub-task
> Components: DataStream API
> Affects Versions: 1.3.0
> Reporter: Stefano Bortoli
> Assignee: Stefano Bortoli
> Fix For: 1.4.0
>
>
> We should support DISTINCT in Code Generated aggrgation functions.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
