GitHub user tzulitai opened a pull request:

    https://github.com/apache/flink/pull/4190

    [FLINK-7011] [kafka] Harden Kafka testStartFromKafkaCommitOffsets ITCases

    Hardens `testStartFromKafkaCommitOffsets` in Kafka ITCases.
    
    **Description of what the test does:**
    The case verifies that whatever offset was committed to Kafka, Flink reads 
it correctly and can use that as the correct starting point for exactly-once. 
It is done in an end-to-end manner, verifying that the commit logic and read 
offset logic is coherent.
    
    **Problem:**
    The previous implementation was too strict. It tries 3 times to fetch some 
committed offsets. If none is fetched, the test fails. This PR changes it so 
that we retry infinitely until some offsets are committed. In the case that no 
offsets are ever committed due to incorrect offset commit logic, the test 
timeouts can guard against that.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tzulitai/flink FLINK-7011

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4190.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4190
    
----
commit 264172d3b788ff73aade75116e8342c132df24c0
Author: Tzu-Li (Gordon) Tai <[email protected]>
Date:   2017-06-27T07:53:06Z

    [FLINK-7011] [kafka] Harden Kafka testStartFromKafkaCommitOffsets ITCases

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to