[ 
https://issues.apache.org/jira/browse/FLINK-6867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064766#comment-16064766
 ] 

ASF GitHub Bot commented on FLINK-6867:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4191#discussion_r124260636
  
    --- Diff: 
flink-connectors/flink-connector-elasticsearch/src/test/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkITCase.java
 ---
    @@ -67,7 +68,11 @@ public void testTransportClientFails() throws Exception{
     
        /**
         * Tests that the Elasticsearch sink works properly using an embedded 
node to connect to Elasticsearch.
    +    *
    +    * NOTE: This is ignored, since executing both embedded client mode and 
transport client mode introduces
    +    * instability for node discovery in ES 1.x. See FLINK-6867.
         */
    +   @Ignore
    --- End diff --
    
    Do we expect to ever enable this test again? if not, let's just remove it.


> Elasticsearch 1.x ITCase still instable due to embedded node instability
> ------------------------------------------------------------------------
>
>                 Key: FLINK-6867
>                 URL: https://issues.apache.org/jira/browse/FLINK-6867
>             Project: Flink
>          Issue Type: Bug
>          Components: ElasticSearch Connector, Tests
>            Reporter: Tzu-Li (Gordon) Tai
>            Assignee: Tzu-Li (Gordon) Tai
>
> The integration tests for Elasticsearch 1.x seems to still be instable, being 
> that the test is failing more frequently recently. One example is [1].
> The last attempt to fix this was FLINK-5772, in which the test attempts was 
> increased to 3. This doesn't seem to fix the issue. In the worst scenario, 
> since the root cause is an instability with Elasticsearch 1.x's embedded 
> node, and ES 1.x is a very old version that is usually recommended to be 
> upgraded from, we could also consider removing the IT test for ES 1.x.
> [1] https://travis-ci.org/apache/flink/jobs/240444523



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to